can someone review my PR?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

can someone review my PR?

Steve Loughran
I've had a PR outstanding on spark/object store integration, works for both maven and sbt builds


Can I get someone to review this as it appears to be being overlooked amongst all the PRs

thanks

-steve
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: can someone review my PR?

Sean Owen
It still doesn't pass tests -- I'd usually not look until that point.

On Wed, Jan 18, 2017 at 11:10 AM Steve Loughran <[hidden email]> wrote:
I've had a PR outstanding on spark/object store integration, works for both maven and sbt builds


Can I get someone to review this as it appears to be being overlooked amongst all the PRs

thanks

-steve
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: can someone review my PR?

Steve Loughran

On 18 Jan 2017, at 11:18, Sean Owen <[hidden email]> wrote:

It still doesn't pass tests -- I'd usually not look until that point.

it's failing on the dependency check as the dependencies have changed. that's what it's meant to do. should I explicitly be changing the values so that the build doesn't notice the change?

On Wed, Jan 18, 2017 at 11:10 AM Steve Loughran <[hidden email]> wrote:
I've had a PR outstanding on spark/object store integration, works for both maven and sbt builds


Can I get someone to review this as it appears to be being overlooked amongst all the PRs

thanks

-steve

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: can someone review my PR?

Marcelo Vanzin
On Wed, Jan 18, 2017 at 6:16 AM, Steve Loughran <[hidden email]> wrote:
> it's failing on the dependency check as the dependencies have changed.
> that's what it's meant to do. should I explicitly be changing the values so
> that the build doesn't notice the change?

Yes. There's no automated way to do that, intentionally.

--
Marcelo

---------------------------------------------------------------------
To unsubscribe e-mail: [hidden email]

Loading...