Running K8s integration tests for changes in core?

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Running K8s integration tests for changes in core?

Holden Karau
Hi Dev Folks,

I was wondering how people feel about enabling the K8s PRB automatically for all core changes? Sometimes I forget that a change might impact one of the K8s integration tests since a bunch of them look at log messages. Would folks be OK with turning on the K8s integration PRB for all core changes as well as K8s changes?

Cheers,

Holden :)

--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 
Reply | Threaded
Open this post in threaded view
|

Re: Running K8s integration tests for changes in core?

shane knapp ☠
yes, i think this is fine.  the k8s prb runs concurrently to the regular prb and takes ~20m.

On Tue, Aug 18, 2020 at 8:47 PM Holden Karau <[hidden email]> wrote:
Hi Dev Folks,

I was wondering how people feel about enabling the K8s PRB automatically for all core changes? Sometimes I forget that a change might impact one of the K8s integration tests since a bunch of them look at log messages. Would folks be OK with turning on the K8s integration PRB for all core changes as well as K8s changes?

Cheers,

Holden :)

--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 


--
Shane Knapp
Computer Guy / Voice of Reason
UC Berkeley EECS Research / RISELab Staff Technical Lead
https://rise.cs.berkeley.edu
Reply | Threaded
Open this post in threaded view
|

Re: Running K8s integration tests for changes in core?

Prashant Sharma
In reply to this post by Holden Karau
+1, we should enable.

On Wed, Aug 19, 2020 at 9:18 AM Holden Karau <[hidden email]> wrote:
Hi Dev Folks,

I was wondering how people feel about enabling the K8s PRB automatically for all core changes? Sometimes I forget that a change might impact one of the K8s integration tests since a bunch of them look at log messages. Would folks be OK with turning on the K8s integration PRB for all core changes as well as K8s changes?

Cheers,

Holden :)

--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 
Reply | Threaded
Open this post in threaded view
|

Re: Running K8s integration tests for changes in core?

Holden Karau
Sounds good. In the meantime would folks committing things in core run the K8s PRB or run it locally? A second change this morning was committed that broke the K8s PR tests.

On Tue, Aug 18, 2020 at 9:53 PM Prashant Sharma <[hidden email]> wrote:
+1, we should enable.

On Wed, Aug 19, 2020 at 9:18 AM Holden Karau <[hidden email]> wrote:
Hi Dev Folks,

I was wondering how people feel about enabling the K8s PRB automatically for all core changes? Sometimes I forget that a change might impact one of the K8s integration tests since a bunch of them look at log messages. Would folks be OK with turning on the K8s integration PRB for all core changes as well as K8s changes?

Cheers,

Holden :)

--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 


--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 
Reply | Threaded
Open this post in threaded view
|

Re: Running K8s integration tests for changes in core?

shane knapp ☠
we'll be gated by the number of ubuntu workers w/minikube and docker, but it shouldn't be too bad as the full integration test takes ~45m, vs 4+ hrs for the regular PRB.

i can enable this in about 1m of time if the consensus is for us to want this.

On Wed, Aug 19, 2020 at 11:37 AM Holden Karau <[hidden email]> wrote:
Sounds good. In the meantime would folks committing things in core run the K8s PRB or run it locally? A second change this morning was committed that broke the K8s PR tests.

On Tue, Aug 18, 2020 at 9:53 PM Prashant Sharma <[hidden email]> wrote:
+1, we should enable.

On Wed, Aug 19, 2020 at 9:18 AM Holden Karau <[hidden email]> wrote:
Hi Dev Folks,

I was wondering how people feel about enabling the K8s PRB automatically for all core changes? Sometimes I forget that a change might impact one of the K8s integration tests since a bunch of them look at log messages. Would folks be OK with turning on the K8s integration PRB for all core changes as well as K8s changes?

Cheers,

Holden :)

--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 


--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 


--
Shane Knapp
Computer Guy / Voice of Reason
UC Berkeley EECS Research / RISELab Staff Technical Lead
https://rise.cs.berkeley.edu
Reply | Threaded
Open this post in threaded view
|

Re: Running K8s integration tests for changes in core?

Prashant Sharma
Another option is, if we could have something like "presubmit" PR build. In other words, running the entire 4 H + K8s integration on each commit pushed is too much at the same time and there are chances that one thing can inadvertently affect other components(as you just said).

A presubmit(which includes K8s integration tests) build will be run, once the PR receives LGTM from "Approved reviewers". This is one criteria that comes to my mind, others may have better suggestions.

On Thu, Aug 20, 2020 at 12:25 AM shane knapp ☠ <[hidden email]> wrote:
we'll be gated by the number of ubuntu workers w/minikube and docker, but it shouldn't be too bad as the full integration test takes ~45m, vs 4+ hrs for the regular PRB.

i can enable this in about 1m of time if the consensus is for us to want this.

On Wed, Aug 19, 2020 at 11:37 AM Holden Karau <[hidden email]> wrote:
Sounds good. In the meantime would folks committing things in core run the K8s PRB or run it locally? A second change this morning was committed that broke the K8s PR tests.

On Tue, Aug 18, 2020 at 9:53 PM Prashant Sharma <[hidden email]> wrote:
+1, we should enable.

On Wed, Aug 19, 2020 at 9:18 AM Holden Karau <[hidden email]> wrote:
Hi Dev Folks,

I was wondering how people feel about enabling the K8s PRB automatically for all core changes? Sometimes I forget that a change might impact one of the K8s integration tests since a bunch of them look at log messages. Would folks be OK with turning on the K8s integration PRB for all core changes as well as K8s changes?

Cheers,

Holden :)

--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 


--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 


--
Shane Knapp
Computer Guy / Voice of Reason
UC Berkeley EECS Research / RISELab Staff Technical Lead
https://rise.cs.berkeley.edu
Reply | Threaded
Open this post in threaded view
|

Re: Running K8s integration tests for changes in core?

shane knapp ☠
fyi, i won't be making this change until the 1st week of september.  i'll be out, off the grid all next week!  :)

i will send an announcement out tomorrow on how to contact my team here @ uc berkeley if jenkins goes down.

shane

On Thu, Aug 20, 2020 at 4:40 AM Prashant Sharma <[hidden email]> wrote:
Another option is, if we could have something like "presubmit" PR build. In other words, running the entire 4 H + K8s integration on each commit pushed is too much at the same time and there are chances that one thing can inadvertently affect other components(as you just said).

A presubmit(which includes K8s integration tests) build will be run, once the PR receives LGTM from "Approved reviewers". This is one criteria that comes to my mind, others may have better suggestions.

On Thu, Aug 20, 2020 at 12:25 AM shane knapp ☠ <[hidden email]> wrote:
we'll be gated by the number of ubuntu workers w/minikube and docker, but it shouldn't be too bad as the full integration test takes ~45m, vs 4+ hrs for the regular PRB.

i can enable this in about 1m of time if the consensus is for us to want this.

On Wed, Aug 19, 2020 at 11:37 AM Holden Karau <[hidden email]> wrote:
Sounds good. In the meantime would folks committing things in core run the K8s PRB or run it locally? A second change this morning was committed that broke the K8s PR tests.

On Tue, Aug 18, 2020 at 9:53 PM Prashant Sharma <[hidden email]> wrote:
+1, we should enable.

On Wed, Aug 19, 2020 at 9:18 AM Holden Karau <[hidden email]> wrote:
Hi Dev Folks,

I was wondering how people feel about enabling the K8s PRB automatically for all core changes? Sometimes I forget that a change might impact one of the K8s integration tests since a bunch of them look at log messages. Would folks be OK with turning on the K8s integration PRB for all core changes as well as K8s changes?

Cheers,

Holden :)

--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 


--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 


--
Shane Knapp
Computer Guy / Voice of Reason
UC Berkeley EECS Research / RISELab Staff Technical Lead
https://rise.cs.berkeley.edu


--
Shane Knapp
Computer Guy / Voice of Reason
UC Berkeley EECS Research / RISELab Staff Technical Lead
https://rise.cs.berkeley.edu
Reply | Threaded
Open this post in threaded view
|

Re: Running K8s integration tests for changes in core?

Holden Karau
Sounds good, thanks for the heads up. I hope you get some time to relax :)

On Thu, Aug 20, 2020 at 2:26 PM shane knapp ☠ <[hidden email]> wrote:
fyi, i won't be making this change until the 1st week of september.  i'll be out, off the grid all next week!  :)

i will send an announcement out tomorrow on how to contact my team here @ uc berkeley if jenkins goes down.

shane

On Thu, Aug 20, 2020 at 4:40 AM Prashant Sharma <[hidden email]> wrote:
Another option is, if we could have something like "presubmit" PR build. In other words, running the entire 4 H + K8s integration on each commit pushed is too much at the same time and there are chances that one thing can inadvertently affect other components(as you just said).

A presubmit(which includes K8s integration tests) build will be run, once the PR receives LGTM from "Approved reviewers". This is one criteria that comes to my mind, others may have better suggestions.

On Thu, Aug 20, 2020 at 12:25 AM shane knapp ☠ <[hidden email]> wrote:
we'll be gated by the number of ubuntu workers w/minikube and docker, but it shouldn't be too bad as the full integration test takes ~45m, vs 4+ hrs for the regular PRB.

i can enable this in about 1m of time if the consensus is for us to want this.

On Wed, Aug 19, 2020 at 11:37 AM Holden Karau <[hidden email]> wrote:
Sounds good. In the meantime would folks committing things in core run the K8s PRB or run it locally? A second change this morning was committed that broke the K8s PR tests.

On Tue, Aug 18, 2020 at 9:53 PM Prashant Sharma <[hidden email]> wrote:
+1, we should enable.

On Wed, Aug 19, 2020 at 9:18 AM Holden Karau <[hidden email]> wrote:
Hi Dev Folks,

I was wondering how people feel about enabling the K8s PRB automatically for all core changes? Sometimes I forget that a change might impact one of the K8s integration tests since a bunch of them look at log messages. Would folks be OK with turning on the K8s integration PRB for all core changes as well as K8s changes?

Cheers,

Holden :)

--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 


--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 


--
Shane Knapp
Computer Guy / Voice of Reason
UC Berkeley EECS Research / RISELab Staff Technical Lead
https://rise.cs.berkeley.edu


--
Shane Knapp
Computer Guy / Voice of Reason
UC Berkeley EECS Research / RISELab Staff Technical Lead
https://rise.cs.berkeley.edu


--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9