Review notification bot

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Review notification bot

Holden Karau
Hi friends,

Was chatting with some folks at the summit and I was wondering how people would feel about adding a review bot to ping folks. We already have the review dashboard but I was thinking we could ping folks who were the original authors of the code being changed whom might not be in the habit of looking at the review dashboard.

Cheers,

Holden :)
--
Reply | Threaded
Open this post in threaded view
|

Re: Review notification bot

Sean Owen-2
Certainly I will frequently dig through 'git blame' to figure out who might be the right reviewer. Maybe that's automatable -- ping the person who last touched the most lines touched by the PR? There might be some false positives there. And I suppose the downside is being pinged forever for some change that just isn't well considered or one of those accidental 100K-line PRs. So maybe some way to decline or silence is important, or maybe just ping once and leave it. Sure, a bot that just adds a "Would @foo like to review?" comment on Github? Sure seems worth trying if someone is willing to do the work to cook up the bot.

On Wed, Jun 6, 2018 at 12:22 PM Holden Karau <[hidden email]> wrote:
Hi friends,

Was chatting with some folks at the summit and I was wondering how people would feel about adding a review bot to ping folks. We already have the review dashboard but I was thinking we could ping folks who were the original authors of the code being changed whom might not be in the habit of looking at the review dashboard.

Cheers,

Holden :)
--
Reply | Threaded
Open this post in threaded view
|

Re: Review notification bot

Holden Karau
So there are a few bots along this line in OSS. If no one objects I’ll take a look and find one which matches our use case and try it out.

On Wed, Jun 6, 2018 at 10:33 AM Sean Owen <[hidden email]> wrote:
Certainly I will frequently dig through 'git blame' to figure out who might be the right reviewer. Maybe that's automatable -- ping the person who last touched the most lines touched by the PR? There might be some false positives there. And I suppose the downside is being pinged forever for some change that just isn't well considered or one of those accidental 100K-line PRs. So maybe some way to decline or silence is important, or maybe just ping once and leave it. Sure, a bot that just adds a "Would @foo like to review?" comment on Github? Sure seems worth trying if someone is willing to do the work to cook up the bot.

On Wed, Jun 6, 2018 at 12:22 PM Holden Karau <[hidden email]> wrote:
Hi friends,

Was chatting with some folks at the summit and I was wondering how people would feel about adding a review bot to ping folks. We already have the review dashboard but I was thinking we could ping folks who were the original authors of the code being changed whom might not be in the habit of looking at the review dashboard.

Cheers,

Holden :)
--
--