Re: Exposing JIRA issue types at GitHub PRs

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Exposing JIRA issue types at GitHub PRs

rxin
Seems like a good idea. Can we test this with a component first?

On Thu, Jun 13, 2019 at 6:17 AM Dongjoon Hyun <[hidden email]> wrote:
Hi, All.

Since we use both Apache JIRA and GitHub actively for Apache Spark contributions, we have lots of JIRAs and PRs consequently. One specific thing I've been longing to see is `Jira Issue Type` in GitHub.

How about exposing JIRA issue types at GitHub PRs as GitHub `Labels`? There are two main benefits:
1. It helps the communication between the contributors and reviewers with more information.
    (In some cases, some people only visit GitHub to see the PR and commits)
2. `Labels` is searchable. We don't need to visit Apache Jira to search PRs to see a specific type.
    (For example, the reviewers can see and review 'BUG' PRs first by using `is:open is:pr label:BUG`.)

Of course, this can be done automatically without human intervention. Since we already have GitHub Jenkins job to access JIRA/GitHub, that job can add the labels from the beginning. If needed, I can volunteer to update the script.

To show the demo, I labeled several PRs manually. You can see the result right now in Apache Spark PR page.


If you're surprised due to those manual activities, I want to apologize for that. I hope we can take advantage of the existing GitHub features to serve Apache Spark community in a way better than yesterday.

How do you think about this specific suggestion?

Bests,
Dongjoon

PS. I saw that `Request Review` and `Assign` features are already used for some purposes, but these feature are out of the scope in this email.
Reply | Threaded
Open this post in threaded view
|

Re: Exposing JIRA issue types at GitHub PRs

Marco Gaido
Hi Dongjoon,
Thanks for the proposal! I like the idea. Maybe we can extend it to component too and to some jira labels such as correctness which may be worth to highlight in PRs too. My only concern is that in many cases JIRAs are created not very carefully so they may be incorrect at the moment of the pr creation and it may be updated later: so keeping them in sync may be an extra effort..

On Thu, 13 Jun 2019, 08:09 Reynold Xin, <[hidden email]> wrote:
Seems like a good idea. Can we test this with a component first?

On Thu, Jun 13, 2019 at 6:17 AM Dongjoon Hyun <[hidden email]> wrote:
Hi, All.

Since we use both Apache JIRA and GitHub actively for Apache Spark contributions, we have lots of JIRAs and PRs consequently. One specific thing I've been longing to see is `Jira Issue Type` in GitHub.

How about exposing JIRA issue types at GitHub PRs as GitHub `Labels`? There are two main benefits:
1. It helps the communication between the contributors and reviewers with more information.
    (In some cases, some people only visit GitHub to see the PR and commits)
2. `Labels` is searchable. We don't need to visit Apache Jira to search PRs to see a specific type.
    (For example, the reviewers can see and review 'BUG' PRs first by using `is:open is:pr label:BUG`.)

Of course, this can be done automatically without human intervention. Since we already have GitHub Jenkins job to access JIRA/GitHub, that job can add the labels from the beginning. If needed, I can volunteer to update the script.

To show the demo, I labeled several PRs manually. You can see the result right now in Apache Spark PR page.


If you're surprised due to those manual activities, I want to apologize for that. I hope we can take advantage of the existing GitHub features to serve Apache Spark community in a way better than yesterday.

How do you think about this specific suggestion?

Bests,
Dongjoon

PS. I saw that `Request Review` and `Assign` features are already used for some purposes, but these feature are out of the scope in this email.
Reply | Threaded
Open this post in threaded view
|

Re: Exposing JIRA issue types at GitHub PRs

Gengliang
Hi Dongjoon, 

+1 with the nice work.
Quick question: if the github_jira_sync script is fully automated, should contributors skip adding the duplicated labels in new PR titles?


On Jun 17, 2019, at 4:21 PM, Gabor Somogyi <[hidden email]> wrote:

Dongjoon, I think it's useful. Thanks for adding it!

On Mon, Jun 17, 2019 at 8:05 AM Dongjoon Hyun <[hidden email]> wrote:
Thank you, Hyukjin !

On Sun, Jun 16, 2019 at 4:12 PM Hyukjin Kwon <[hidden email]> wrote:
Labels look good and useful.

On Sat, 15 Jun 2019, 02:36 Dongjoon Hyun, <[hidden email]> wrote:
Now, you can see the exposed component labels (ordered by the number of PRs) here and click the component to search.


Dongjoon.


On Fri, Jun 14, 2019 at 1:15 AM Dongjoon Hyun <[hidden email]> wrote:
Hi, All.

JIRA and PR is ready for reviews.

https://issues.apache.org/jira/browse/SPARK-28051 (Exposing JIRA issue component types at GitHub PRs)

Bests,
Dongjoon.


On Thu, Jun 13, 2019 at 10:48 AM Dongjoon Hyun <[hidden email]> wrote:
Thank you for the feedbacks and requirements, Hyukjin, Reynold, Marco.

Sure, we can do whatever we want.

I'll wait for more feedbacks and proceed to the next steps.

Bests,
Dongjoon.


On Wed, Jun 12, 2019 at 11:51 PM Marco Gaido <[hidden email]> wrote:
Hi Dongjoon,
Thanks for the proposal! I like the idea. Maybe we can extend it to component too and to some jira labels such as correctness which may be worth to highlight in PRs too. My only concern is that in many cases JIRAs are created not very carefully so they may be incorrect at the moment of the pr creation and it may be updated later: so keeping them in sync may be an extra effort..

On Thu, 13 Jun 2019, 08:09 Reynold Xin, <[hidden email]> wrote:
Seems like a good idea. Can we test this with a component first?

On Thu, Jun 13, 2019 at 6:17 AM Dongjoon Hyun <[hidden email]> wrote:
Hi, All.

Since we use both Apache JIRA and GitHub actively for Apache Spark contributions, we have lots of JIRAs and PRs consequently. One specific thing I've been longing to see is `Jira Issue Type` in GitHub.

How about exposing JIRA issue types at GitHub PRs as GitHub `Labels`? There are two main benefits:
1. It helps the communication between the contributors and reviewers with more information.
    (In some cases, some people only visit GitHub to see the PR and commits)
2. `Labels` is searchable. We don't need to visit Apache Jira to search PRs to see a specific type.
    (For example, the reviewers can see and review 'BUG' PRs first by using `is:open is:pr label:BUG`.)

Of course, this can be done automatically without human intervention. Since we already have GitHub Jenkins job to access JIRA/GitHub, that job can add the labels from the beginning. If needed, I can volunteer to update the script.

To show the demo, I labeled several PRs manually. You can see the result right now in Apache Spark PR page.


If you're surprised due to those manual activities, I want to apologize for that. I hope we can take advantage of the existing GitHub features to serve Apache Spark community in a way better than yesterday.

How do you think about this specific suggestion?

Bests,
Dongjoon

PS. I saw that `Request Review` and `Assign` features are already used for some purposes, but these feature are out of the scope in this email.

Reply | Threaded
Open this post in threaded view
|

Re: Exposing JIRA issue types at GitHub PRs

Gabor Somogyi-2
Does the label merged into the commit? Somehow it would be still good to see component in the msg.

G

On Wed, Jun 19, 2019 at 11:09 AM Gengliang Wang <[hidden email]> wrote:
Hi Dongjoon, 

+1 with the nice work.
Quick question: if the github_jira_sync script is fully automated, should contributors skip adding the duplicated labels in new PR titles?


On Jun 17, 2019, at 4:21 PM, Gabor Somogyi <[hidden email]> wrote:

Dongjoon, I think it's useful. Thanks for adding it!

On Mon, Jun 17, 2019 at 8:05 AM Dongjoon Hyun <[hidden email]> wrote:
Thank you, Hyukjin !

On Sun, Jun 16, 2019 at 4:12 PM Hyukjin Kwon <[hidden email]> wrote:
Labels look good and useful.

On Sat, 15 Jun 2019, 02:36 Dongjoon Hyun, <[hidden email]> wrote:
Now, you can see the exposed component labels (ordered by the number of PRs) here and click the component to search.


Dongjoon.


On Fri, Jun 14, 2019 at 1:15 AM Dongjoon Hyun <[hidden email]> wrote:
Hi, All.

JIRA and PR is ready for reviews.

https://issues.apache.org/jira/browse/SPARK-28051 (Exposing JIRA issue component types at GitHub PRs)

Bests,
Dongjoon.


On Thu, Jun 13, 2019 at 10:48 AM Dongjoon Hyun <[hidden email]> wrote:
Thank you for the feedbacks and requirements, Hyukjin, Reynold, Marco.

Sure, we can do whatever we want.

I'll wait for more feedbacks and proceed to the next steps.

Bests,
Dongjoon.


On Wed, Jun 12, 2019 at 11:51 PM Marco Gaido <[hidden email]> wrote:
Hi Dongjoon,
Thanks for the proposal! I like the idea. Maybe we can extend it to component too and to some jira labels such as correctness which may be worth to highlight in PRs too. My only concern is that in many cases JIRAs are created not very carefully so they may be incorrect at the moment of the pr creation and it may be updated later: so keeping them in sync may be an extra effort..

On Thu, 13 Jun 2019, 08:09 Reynold Xin, <[hidden email]> wrote:
Seems like a good idea. Can we test this with a component first?

On Thu, Jun 13, 2019 at 6:17 AM Dongjoon Hyun <[hidden email]> wrote:
Hi, All.

Since we use both Apache JIRA and GitHub actively for Apache Spark contributions, we have lots of JIRAs and PRs consequently. One specific thing I've been longing to see is `Jira Issue Type` in GitHub.

How about exposing JIRA issue types at GitHub PRs as GitHub `Labels`? There are two main benefits:
1. It helps the communication between the contributors and reviewers with more information.
    (In some cases, some people only visit GitHub to see the PR and commits)
2. `Labels` is searchable. We don't need to visit Apache Jira to search PRs to see a specific type.
    (For example, the reviewers can see and review 'BUG' PRs first by using `is:open is:pr label:BUG`.)

Of course, this can be done automatically without human intervention. Since we already have GitHub Jenkins job to access JIRA/GitHub, that job can add the labels from the beginning. If needed, I can volunteer to update the script.

To show the demo, I labeled several PRs manually. You can see the result right now in Apache Spark PR page.


If you're surprised due to those manual activities, I want to apologize for that. I hope we can take advantage of the existing GitHub features to serve Apache Spark community in a way better than yesterday.

How do you think about this specific suggestion?

Bests,
Dongjoon

PS. I saw that `Request Review` and `Assign` features are already used for some purposes, but these feature are out of the scope in this email.

Reply | Threaded
Open this post in threaded view
|

Re: Exposing JIRA issue types at GitHub PRs

Dongjoon Hyun-2
Thank you for feedback, Gengliang and Gabor!

Yes. The commit title and message is still important. There will be no change for the existing PR title policy.
I've received AmpLab Jenkins permission yesterday. I'm looking at the infra.

Bests,
Dongjoon.


On Wed, Jun 19, 2019 at 2:46 AM Gabor Somogyi <[hidden email]> wrote:
Does the label merged into the commit? Somehow it would be still good to see component in the msg.

G

On Wed, Jun 19, 2019 at 11:09 AM Gengliang Wang <[hidden email]> wrote:
Hi Dongjoon, 

+1 with the nice work.
Quick question: if the github_jira_sync script is fully automated, should contributors skip adding the duplicated labels in new PR titles?


On Jun 17, 2019, at 4:21 PM, Gabor Somogyi <[hidden email]> wrote:

Dongjoon, I think it's useful. Thanks for adding it!

On Mon, Jun 17, 2019 at 8:05 AM Dongjoon Hyun <[hidden email]> wrote:
Thank you, Hyukjin !

On Sun, Jun 16, 2019 at 4:12 PM Hyukjin Kwon <[hidden email]> wrote:
Labels look good and useful.

On Sat, 15 Jun 2019, 02:36 Dongjoon Hyun, <[hidden email]> wrote:
Now, you can see the exposed component labels (ordered by the number of PRs) here and click the component to search.


Dongjoon.


On Fri, Jun 14, 2019 at 1:15 AM Dongjoon Hyun <[hidden email]> wrote:
Hi, All.

JIRA and PR is ready for reviews.

https://issues.apache.org/jira/browse/SPARK-28051 (Exposing JIRA issue component types at GitHub PRs)

Bests,
Dongjoon.


On Thu, Jun 13, 2019 at 10:48 AM Dongjoon Hyun <[hidden email]> wrote:
Thank you for the feedbacks and requirements, Hyukjin, Reynold, Marco.

Sure, we can do whatever we want.

I'll wait for more feedbacks and proceed to the next steps.

Bests,
Dongjoon.


On Wed, Jun 12, 2019 at 11:51 PM Marco Gaido <[hidden email]> wrote:
Hi Dongjoon,
Thanks for the proposal! I like the idea. Maybe we can extend it to component too and to some jira labels such as correctness which may be worth to highlight in PRs too. My only concern is that in many cases JIRAs are created not very carefully so they may be incorrect at the moment of the pr creation and it may be updated later: so keeping them in sync may be an extra effort..

On Thu, 13 Jun 2019, 08:09 Reynold Xin, <[hidden email]> wrote:
Seems like a good idea. Can we test this with a component first?

On Thu, Jun 13, 2019 at 6:17 AM Dongjoon Hyun <[hidden email]> wrote:
Hi, All.

Since we use both Apache JIRA and GitHub actively for Apache Spark contributions, we have lots of JIRAs and PRs consequently. One specific thing I've been longing to see is `Jira Issue Type` in GitHub.

How about exposing JIRA issue types at GitHub PRs as GitHub `Labels`? There are two main benefits:
1. It helps the communication between the contributors and reviewers with more information.
    (In some cases, some people only visit GitHub to see the PR and commits)
2. `Labels` is searchable. We don't need to visit Apache Jira to search PRs to see a specific type.
    (For example, the reviewers can see and review 'BUG' PRs first by using `is:open is:pr label:BUG`.)

Of course, this can be done automatically without human intervention. Since we already have GitHub Jenkins job to access JIRA/GitHub, that job can add the labels from the beginning. If needed, I can volunteer to update the script.

To show the demo, I labeled several PRs manually. You can see the result right now in Apache Spark PR page.


If you're surprised due to those manual activities, I want to apologize for that. I hope we can take advantage of the existing GitHub features to serve Apache Spark community in a way better than yesterday.

How do you think about this specific suggestion?

Bests,
Dongjoon

PS. I saw that `Request Review` and `Assign` features are already used for some purposes, but these feature are out of the scope in this email.

Reply | Threaded
Open this post in threaded view
|

Re: Exposing JIRA issue types at GitHub PRs

Dongjoon Hyun-2
Hi, All.

During migrating my account to Apache bot, I noticed that ASF policy doesn't allow a bot to have write access to the repository.
JIRA bot can be a contributor to Spark project and have some privileges like changing the issue status.
But, GitHub is a combination of JIRA + Git repo, and LABEL operation needs `WRITE` permissions to the repository although it's not a source code.


There were other INFRA JIRA issues about requesting label operations and those are closed due to the same policy.
The policy is reasonable and also Spark community doesn't allow the bot has committer's API key for security reason.

Sorry for missing this policy from the beginning. I'll post again after rethinking about this migration for a while.

Bests,
Dongjoon.


On Wed, Jun 19, 2019 at 11:03 AM Dongjoon Hyun <[hidden email]> wrote:
Thank you for feedback, Gengliang and Gabor!

Yes. The commit title and message is still important. There will be no change for the existing PR title policy.
I've received AmpLab Jenkins permission yesterday. I'm looking at the infra.

Bests,
Dongjoon.


On Wed, Jun 19, 2019 at 2:46 AM Gabor Somogyi <[hidden email]> wrote:
Does the label merged into the commit? Somehow it would be still good to see component in the msg.

G

On Wed, Jun 19, 2019 at 11:09 AM Gengliang Wang <[hidden email]> wrote:
Hi Dongjoon, 

+1 with the nice work.
Quick question: if the github_jira_sync script is fully automated, should contributors skip adding the duplicated labels in new PR titles?


On Jun 17, 2019, at 4:21 PM, Gabor Somogyi <[hidden email]> wrote:

Dongjoon, I think it's useful. Thanks for adding it!

On Mon, Jun 17, 2019 at 8:05 AM Dongjoon Hyun <[hidden email]> wrote:
Thank you, Hyukjin !

On Sun, Jun 16, 2019 at 4:12 PM Hyukjin Kwon <[hidden email]> wrote:
Labels look good and useful.

On Sat, 15 Jun 2019, 02:36 Dongjoon Hyun, <[hidden email]> wrote:
Now, you can see the exposed component labels (ordered by the number of PRs) here and click the component to search.


Dongjoon.


On Fri, Jun 14, 2019 at 1:15 AM Dongjoon Hyun <[hidden email]> wrote:
Hi, All.

JIRA and PR is ready for reviews.

https://issues.apache.org/jira/browse/SPARK-28051 (Exposing JIRA issue component types at GitHub PRs)

Bests,
Dongjoon.


On Thu, Jun 13, 2019 at 10:48 AM Dongjoon Hyun <[hidden email]> wrote:
Thank you for the feedbacks and requirements, Hyukjin, Reynold, Marco.

Sure, we can do whatever we want.

I'll wait for more feedbacks and proceed to the next steps.

Bests,
Dongjoon.


On Wed, Jun 12, 2019 at 11:51 PM Marco Gaido <[hidden email]> wrote:
Hi Dongjoon,
Thanks for the proposal! I like the idea. Maybe we can extend it to component too and to some jira labels such as correctness which may be worth to highlight in PRs too. My only concern is that in many cases JIRAs are created not very carefully so they may be incorrect at the moment of the pr creation and it may be updated later: so keeping them in sync may be an extra effort..

On Thu, 13 Jun 2019, 08:09 Reynold Xin, <[hidden email]> wrote:
Seems like a good idea. Can we test this with a component first?

On Thu, Jun 13, 2019 at 6:17 AM Dongjoon Hyun <[hidden email]> wrote:
Hi, All.

Since we use both Apache JIRA and GitHub actively for Apache Spark contributions, we have lots of JIRAs and PRs consequently. One specific thing I've been longing to see is `Jira Issue Type` in GitHub.

How about exposing JIRA issue types at GitHub PRs as GitHub `Labels`? There are two main benefits:
1. It helps the communication between the contributors and reviewers with more information.
    (In some cases, some people only visit GitHub to see the PR and commits)
2. `Labels` is searchable. We don't need to visit Apache Jira to search PRs to see a specific type.
    (For example, the reviewers can see and review 'BUG' PRs first by using `is:open is:pr label:BUG`.)

Of course, this can be done automatically without human intervention. Since we already have GitHub Jenkins job to access JIRA/GitHub, that job can add the labels from the beginning. If needed, I can volunteer to update the script.

To show the demo, I labeled several PRs manually. You can see the result right now in Apache Spark PR page.


If you're surprised due to those manual activities, I want to apologize for that. I hope we can take advantage of the existing GitHub features to serve Apache Spark community in a way better than yesterday.

How do you think about this specific suggestion?

Bests,
Dongjoon

PS. I saw that `Request Review` and `Assign` features are already used for some purposes, but these feature are out of the scope in this email.