[PSA] Apache Spark uses GitHub Actions to run the tests

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PSA] Apache Spark uses GitHub Actions to run the tests

Hyukjin Kwon
Hi dev,

Github Actions build was introduced to run the regular Spark test cases at https://github.com/apache/spark/pull/29057and https://github.com/apache/spark/pull/29086.
This is virtually the duplication of default Jenkins PR builder at this moment.

The only differences are:
- Github Actions does not run the tests for Kinesis, see SPARK-32246
- Github Actions does not support other profiles such as JDK 11 or Hive 1.2, see SPARK-32255
- Jenkins build does not run Java documentation build, see SPARK-32233
- Jenkins build does not run the dependency test, see SPARK-32178

Therefore, I do believe PRs can be merged in most general cases once the Jenkins PR
builder or Github Actions build passes when we expect the successful test results from
the default Jenkins PR builder.

Thanks.
Reply | Threaded
Open this post in threaded view
|

Re: [PSA] Apache Spark uses GitHub Actions to run the tests

cloud0fan
To clarify, we need to wait for:
1. Java documentation build test in github actions
2. dependency test in github actions
3. either github action all green or jenkin pass

If the PR touches Kinesis, or it uses other profiles, we must wait for jenkins to pass.

Do I miss something?

On Tue, Jul 14, 2020 at 2:18 PM Hyukjin Kwon <[hidden email]> wrote:
Hi dev,

Github Actions build was introduced to run the regular Spark test cases at https://github.com/apache/spark/pull/29057and https://github.com/apache/spark/pull/29086.
This is virtually the duplication of default Jenkins PR builder at this moment.

The only differences are:
- Github Actions does not run the tests for Kinesis, see SPARK-32246
- Github Actions does not support other profiles such as JDK 11 or Hive 1.2, see SPARK-32255
- Jenkins build does not run Java documentation build, see SPARK-32233
- Jenkins build does not run the dependency test, see SPARK-32178

Therefore, I do believe PRs can be merged in most general cases once the Jenkins PR
builder or Github Actions build passes when we expect the successful test results from
the default Jenkins PR builder.

Thanks.
Reply | Threaded
Open this post in threaded view
|

Re: [PSA] Apache Spark uses GitHub Actions to run the tests

Hyukjin Kwon
Perfect. Plus, Github Actions is only for master branch at this moment.

BTW, I think we can enable Java(Scala) doc build and dependency test back in Jenkins for simplicity.
Seems like the Jenkins machine came back to normal.

2020년 7월 14일 (화) 오후 4:08, Wenchen Fan <[hidden email]>님이 작성:
To clarify, we need to wait for:
1. Java documentation build test in github actions
2. dependency test in github actions
3. either github action all green or jenkin pass

If the PR touches Kinesis, or it uses other profiles, we must wait for jenkins to pass.

Do I miss something?

On Tue, Jul 14, 2020 at 2:18 PM Hyukjin Kwon <[hidden email]> wrote:
Hi dev,

Github Actions build was introduced to run the regular Spark test cases at https://github.com/apache/spark/pull/29057and https://github.com/apache/spark/pull/29086.
This is virtually the duplication of default Jenkins PR builder at this moment.

The only differences are:
- Github Actions does not run the tests for Kinesis, see SPARK-32246
- Github Actions does not support other profiles such as JDK 11 or Hive 1.2, see SPARK-32255
- Jenkins build does not run Java documentation build, see SPARK-32233
- Jenkins build does not run the dependency test, see SPARK-32178

Therefore, I do believe PRs can be merged in most general cases once the Jenkins PR
builder or Github Actions build passes when we expect the successful test results from
the default Jenkins PR builder.

Thanks.
Reply | Threaded
Open this post in threaded view
|

Re: [PSA] Apache Spark uses GitHub Actions to run the tests

Takeshi Yamamuro
Thanks, Hyukjin!

> Therefore, I do believe PRs can be merged in most general cases once the Jenkins PR
builder or Github Actions build passes

greatly helpful!

Bests,
Takeshi

On Tue, Jul 14, 2020 at 4:14 PM Hyukjin Kwon <[hidden email]> wrote:
Perfect. Plus, Github Actions is only for master branch at this moment.

BTW, I think we can enable Java(Scala) doc build and dependency test back in Jenkins for simplicity.
Seems like the Jenkins machine came back to normal.

2020년 7월 14일 (화) 오후 4:08, Wenchen Fan <[hidden email]>님이 작성:
To clarify, we need to wait for:
1. Java documentation build test in github actions
2. dependency test in github actions
3. either github action all green or jenkin pass

If the PR touches Kinesis, or it uses other profiles, we must wait for jenkins to pass.

Do I miss something?

On Tue, Jul 14, 2020 at 2:18 PM Hyukjin Kwon <[hidden email]> wrote:
Hi dev,

Github Actions build was introduced to run the regular Spark test cases at https://github.com/apache/spark/pull/29057and https://github.com/apache/spark/pull/29086.
This is virtually the duplication of default Jenkins PR builder at this moment.

The only differences are:
- Github Actions does not run the tests for Kinesis, see SPARK-32246
- Github Actions does not support other profiles such as JDK 11 or Hive 1.2, see SPARK-32255
- Jenkins build does not run Java documentation build, see SPARK-32233
- Jenkins build does not run the dependency test, see SPARK-32178

Therefore, I do believe PRs can be merged in most general cases once the Jenkins PR
builder or Github Actions build passes when we expect the successful test results from
the default Jenkins PR builder.

Thanks.


--
---
Takeshi Yamamuro
Reply | Threaded
Open this post in threaded view
|

Re: [PSA] Apache Spark uses GitHub Actions to run the tests

Holden Karau
This has already helped me catch a potential flaky test I might have otherwise missed. So excited for this additional signal :)

On Tue, Jul 14, 2020 at 6:19 PM Takeshi Yamamuro <[hidden email]> wrote:
Thanks, Hyukjin!

> Therefore, I do believe PRs can be merged in most general cases once the Jenkins PR
builder or Github Actions build passes

greatly helpful!

Bests,
Takeshi

On Tue, Jul 14, 2020 at 4:14 PM Hyukjin Kwon <[hidden email]> wrote:
Perfect. Plus, Github Actions is only for master branch at this moment.

BTW, I think we can enable Java(Scala) doc build and dependency test back in Jenkins for simplicity.
Seems like the Jenkins machine came back to normal.

2020년 7월 14일 (화) 오후 4:08, Wenchen Fan <[hidden email]>님이 작성:
To clarify, we need to wait for:
1. Java documentation build test in github actions
2. dependency test in github actions
3. either github action all green or jenkin pass

If the PR touches Kinesis, or it uses other profiles, we must wait for jenkins to pass.

Do I miss something?

On Tue, Jul 14, 2020 at 2:18 PM Hyukjin Kwon <[hidden email]> wrote:
Hi dev,

Github Actions build was introduced to run the regular Spark test cases at https://github.com/apache/spark/pull/29057and https://github.com/apache/spark/pull/29086.
This is virtually the duplication of default Jenkins PR builder at this moment.

The only differences are:
- Github Actions does not run the tests for Kinesis, see SPARK-32246
- Github Actions does not support other profiles such as JDK 11 or Hive 1.2, see SPARK-32255
- Jenkins build does not run Java documentation build, see SPARK-32233
- Jenkins build does not run the dependency test, see SPARK-32178

Therefore, I do believe PRs can be merged in most general cases once the Jenkins PR
builder or Github Actions build passes when we expect the successful test results from
the default Jenkins PR builder.

Thanks.


--
---
Takeshi Yamamuro


--
Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 
Reply | Threaded
Open this post in threaded view
|

Re: [PSA] Apache Spark uses GitHub Actions to run the tests

Imran Rashid-5
In reply to this post by Hyukjin Kwon
Thanks for setting this up, Hyukjin.

How do you re-trigger tests in github actions?  Eg. there is a failure that appears to be some random infra thing or a flaky test, or maybe the tests were just run a while back so you want to get a fresh batch of tests.  I think the old "Jenkins, retest this please" will still run tests via Jenkins, and so does the button on spark-prs.appspot.com ?

From a tiny bit of searching, it looks like we might need to add the "workflow dispatch" to the github action configuration as indicated here? https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/

thanks,
Imran

On Tue, Jul 14, 2020 at 1:18 AM Hyukjin Kwon <[hidden email]> wrote:
Hi dev,

Github Actions build was introduced to run the regular Spark test cases at https://github.com/apache/spark/pull/29057and https://github.com/apache/spark/pull/29086.
This is virtually the duplication of default Jenkins PR builder at this moment.

The only differences are:
- Github Actions does not run the tests for Kinesis, see SPARK-32246
- Github Actions does not support other profiles such as JDK 11 or Hive 1.2, see SPARK-32255
- Jenkins build does not run Java documentation build, see SPARK-32233
- Jenkins build does not run the dependency test, see SPARK-32178

Therefore, I do believe PRs can be merged in most general cases once the Jenkins PR
builder or Github Actions build passes when we expect the successful test results from
the default Jenkins PR builder.

Thanks.
Reply | Threaded
Open this post in threaded view
|

Re: [PSA] Apache Spark uses GitHub Actions to run the tests

Hyukjin Kwon

Ah, it doesn’t have an integration with the PR dashboard for now.
Imran, have you set up this? Once you have the write access directly to the GitHub repo, I think you will be able to see the “Re-run jobs” button:

Screen Shot 2020-07-24 at 9.40.03 AM.png


It is true that the PR author ideally should be able to rerun it too but seems not possible like some of other CIs.
For now, authors could simply push empty commits or rebase to retrigger for now.



2020년 7월 24일 (금) 오전 7:10, Imran Rashid <[hidden email]>님이 작성:
Thanks for setting this up, Hyukjin.

How do you re-trigger tests in github actions?  Eg. there is a failure that appears to be some random infra thing or a flaky test, or maybe the tests were just run a while back so you want to get a fresh batch of tests.  I think the old "Jenkins, retest this please" will still run tests via Jenkins, and so does the button on spark-prs.appspot.com ?

From a tiny bit of searching, it looks like we might need to add the "workflow dispatch" to the github action configuration as indicated here? https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/

thanks,
Imran

On Tue, Jul 14, 2020 at 1:18 AM Hyukjin Kwon <[hidden email]> wrote:
Hi dev,

Github Actions build was introduced to run the regular Spark test cases at https://github.com/apache/spark/pull/29057and https://github.com/apache/spark/pull/29086.
This is virtually the duplication of default Jenkins PR builder at this moment.

The only differences are:
- Github Actions does not run the tests for Kinesis, see SPARK-32246
- Github Actions does not support other profiles such as JDK 11 or Hive 1.2, see SPARK-32255
- Jenkins build does not run Java documentation build, see SPARK-32233
- Jenkins build does not run the dependency test, see SPARK-32178

Therefore, I do believe PRs can be merged in most general cases once the Jenkins PR
builder or Github Actions build passes when we expect the successful test results from
the default Jenkins PR builder.

Thanks.