Feedback on first commit + jira issue I opened

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Feedback on first commit + jira issue I opened

Long, Andrew

Hello Friends,

 

I’m a new committer and I’ve submitted my first patch and I had some questions about documentation standards.  In my patch(jira below)  I’ve added a config parameter to adjust the number of records show when a user calls .show() on a dataframe.  I was hoping someone could double check my small diff to make sure I wasn’t making any rookie mistakes before I submit a pull request.

 

https://issues.apache.org/jira/browse/SPARK-24442

 

Cheers Andrew

Reply | Threaded
Open this post in threaded view
|

Re: Feedback on first commit + jira issue I opened

Bryan Cutler
Hi Andrew,

Please just go ahead and make the pull request.  It's easier to review and give feedback, thanks!

Bryan

On Thu, May 31, 2018 at 9:44 AM, Long, Andrew <[hidden email]> wrote:

Hello Friends,

 

I’m a new committer and I’ve submitted my first patch and I had some questions about documentation standards.  In my patch(jira below)  I’ve added a config parameter to adjust the number of records show when a user calls .show() on a dataframe.  I was hoping someone could double check my small diff to make sure I wasn’t making any rookie mistakes before I submit a pull request.

 

https://issues.apache.org/jira/browse/SPARK-24442

 

Cheers Andrew