Disabling `Merge Commits` from GitHub Merge Button

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Disabling `Merge Commits` from GitHub Merge Button

Dongjoon Hyun-2
Hi, Apache Spark PMC members and committers.

We are using GitHub `Merge Button` in `spark-website` repository
because it's very convenient.


In order to be consistent with our previous behavior,
can we disable `Allow Merge Commits` from GitHub `Merge Button` setting explicitly?

I hope we can enforce it in both `spark-website` and `spark` repository consistently.

Bests,
Dongjoon.
Reply | Threaded
Open this post in threaded view
|

Re: Disabling `Merge Commits` from GitHub Merge Button

rxin
That's a good idea. We should only be using squash.


On Mon, Jul 01, 2019 at 1:52 PM, Dongjoon Hyun <[hidden email]> wrote:
Hi, Apache Spark PMC members and committers.

We are using GitHub `Merge Button` in `spark-website` repository
because it's very convenient.


In order to be consistent with our previous behavior,
can we disable `Allow Merge Commits` from GitHub `Merge Button` setting explicitly?

I hope we can enforce it in both `spark-website` and `spark` repository consistently.

Bests,
Dongjoon.

Reply | Threaded
Open this post in threaded view
|

Re: Disabling `Merge Commits` from GitHub Merge Button

Sean Owen-2
In reply to this post by Dongjoon Hyun-2
I'm using the merge script in both repos. I think that was the best practice?
So, sure, I'm fine with disabling it.

On Mon, Jul 1, 2019 at 3:53 PM Dongjoon Hyun <[hidden email]> wrote:

>
> Hi, Apache Spark PMC members and committers.
>
> We are using GitHub `Merge Button` in `spark-website` repository
> because it's very convenient.
>
>     1. https://github.com/apache/spark-website/commits/asf-site
>     2. https://github.com/apache/spark/commits/master
>
> In order to be consistent with our previous behavior,
> can we disable `Allow Merge Commits` from GitHub `Merge Button` setting explicitly?
>
> I hope we can enforce it in both `spark-website` and `spark` repository consistently.
>
> Bests,
> Dongjoon.

---------------------------------------------------------------------
To unsubscribe e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Disabling `Merge Commits` from GitHub Merge Button

Takeshi Yamamuro
I'm also using the script in both cases, anyway +1.

On Tue, Jul 2, 2019 at 5:58 AM Sean Owen <[hidden email]> wrote:
I'm using the merge script in both repos. I think that was the best practice?
So, sure, I'm fine with disabling it.

On Mon, Jul 1, 2019 at 3:53 PM Dongjoon Hyun <[hidden email]> wrote:
>
> Hi, Apache Spark PMC members and committers.
>
> We are using GitHub `Merge Button` in `spark-website` repository
> because it's very convenient.
>
>     1. https://github.com/apache/spark-website/commits/asf-site
>     2. https://github.com/apache/spark/commits/master
>
> In order to be consistent with our previous behavior,
> can we disable `Allow Merge Commits` from GitHub `Merge Button` setting explicitly?
>
> I hope we can enforce it in both `spark-website` and `spark` repository consistently.
>
> Bests,
> Dongjoon.

---------------------------------------------------------------------
To unsubscribe e-mail: [hidden email]



--
---
Takeshi Yamamuro
Reply | Threaded
Open this post in threaded view
|

Re: Disabling `Merge Commits` from GitHub Merge Button

Hyukjin Kwon
+1

2019년 7월 2일 (화) 오전 9:39, Takeshi Yamamuro <[hidden email]>님이 작성:
I'm also using the script in both cases, anyway +1.

On Tue, Jul 2, 2019 at 5:58 AM Sean Owen <[hidden email]> wrote:
I'm using the merge script in both repos. I think that was the best practice?
So, sure, I'm fine with disabling it.

On Mon, Jul 1, 2019 at 3:53 PM Dongjoon Hyun <[hidden email]> wrote:
>
> Hi, Apache Spark PMC members and committers.
>
> We are using GitHub `Merge Button` in `spark-website` repository
> because it's very convenient.
>
>     1. https://github.com/apache/spark-website/commits/asf-site
>     2. https://github.com/apache/spark/commits/master
>
> In order to be consistent with our previous behavior,
> can we disable `Allow Merge Commits` from GitHub `Merge Button` setting explicitly?
>
> I hope we can enforce it in both `spark-website` and `spark` repository consistently.
>
> Bests,
> Dongjoon.

---------------------------------------------------------------------
To unsubscribe e-mail: [hidden email]



--
---
Takeshi Yamamuro
Reply | Threaded
Open this post in threaded view
|

Re: Disabling `Merge Commits` from GitHub Merge Button

Dongjoon Hyun-2
Thank you so much for the replies, Reynold, Sean, Takeshi, Hyukjin!

Bests,
Dongjoon.

On Mon, Jul 1, 2019 at 6:00 PM Hyukjin Kwon <[hidden email]> wrote:
+1

2019년 7월 2일 (화) 오전 9:39, Takeshi Yamamuro <[hidden email]>님이 작성:
I'm also using the script in both cases, anyway +1.

On Tue, Jul 2, 2019 at 5:58 AM Sean Owen <[hidden email]> wrote:
I'm using the merge script in both repos. I think that was the best practice?
So, sure, I'm fine with disabling it.

On Mon, Jul 1, 2019 at 3:53 PM Dongjoon Hyun <[hidden email]> wrote:
>
> Hi, Apache Spark PMC members and committers.
>
> We are using GitHub `Merge Button` in `spark-website` repository
> because it's very convenient.
>
>     1. https://github.com/apache/spark-website/commits/asf-site
>     2. https://github.com/apache/spark/commits/master
>
> In order to be consistent with our previous behavior,
> can we disable `Allow Merge Commits` from GitHub `Merge Button` setting explicitly?
>
> I hope we can enforce it in both `spark-website` and `spark` repository consistently.
>
> Bests,
> Dongjoon.

---------------------------------------------------------------------
To unsubscribe e-mail: [hidden email]



--
---
Takeshi Yamamuro
Reply | Threaded
Open this post in threaded view
|

Re: Disabling `Merge Commits` from GitHub Merge Button

cloud0fan
+1 as well

On Tue, Jul 2, 2019 at 12:13 PM Dongjoon Hyun <[hidden email]> wrote:
Thank you so much for the replies, Reynold, Sean, Takeshi, Hyukjin!

Bests,
Dongjoon.

On Mon, Jul 1, 2019 at 6:00 PM Hyukjin Kwon <[hidden email]> wrote:
+1

2019년 7월 2일 (화) 오전 9:39, Takeshi Yamamuro <[hidden email]>님이 작성:
I'm also using the script in both cases, anyway +1.

On Tue, Jul 2, 2019 at 5:58 AM Sean Owen <[hidden email]> wrote:
I'm using the merge script in both repos. I think that was the best practice?
So, sure, I'm fine with disabling it.

On Mon, Jul 1, 2019 at 3:53 PM Dongjoon Hyun <[hidden email]> wrote:
>
> Hi, Apache Spark PMC members and committers.
>
> We are using GitHub `Merge Button` in `spark-website` repository
> because it's very convenient.
>
>     1. https://github.com/apache/spark-website/commits/asf-site
>     2. https://github.com/apache/spark/commits/master
>
> In order to be consistent with our previous behavior,
> can we disable `Allow Merge Commits` from GitHub `Merge Button` setting explicitly?
>
> I hope we can enforce it in both `spark-website` and `spark` repository consistently.
>
> Bests,
> Dongjoon.

---------------------------------------------------------------------
To unsubscribe e-mail: [hidden email]



--
---
Takeshi Yamamuro